| commit | b488527ebeb3b335854f2290aa1c6cf80f464eb0 | |
| author | David Gustafsson <david.gustafsson@ub.gu.se> | |
| Thu, 26 Sep 2019 09:50:14 +0000 (26 11:50 +0200) | ||
| committer | Martin Renvoize <martin.renvoize@ptfs-europe.com> | |
| Mon, 7 Oct 2019 13:09:11 +0000 (7 14:09 +0100) | ||
| tree | 544419dbca6886e5a1f9252b3950ecc815176b4f | treesnapshot (tar.gz zip) |
| parent | dd18ec355bcd369b4d9b1017caf0851d067cf811 | commitdiff |
Bug 23680: Incorrect conversion of Perl boolean to js
A Perl boolean value is on the server side converted
to a JS string (resulting in the values '0' or '1).
Since the string '0' is a truthy value in JS this
incorrectly triggers window.close() on the client
in many instances, for example when adding a new item.
To test:
1. Go to a bibliographic record in the staff client.
2. Expand the "New" menu and open "New item" in new tab.
3. The new tab will immediately close.
4. Apply the patch.
5. Perform steps 1-2 again.
6. The tab should now remain open.
Sponsored-by: Gothenburg University Library
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
A Perl boolean value is on the server side converted
to a JS string (resulting in the values '0' or '1).
Since the string '0' is a truthy value in JS this
incorrectly triggers window.close() on the client
in many instances, for example when adding a new item.
To test:
1. Go to a bibliographic record in the staff client.
2. Expand the "New" menu and open "New item" in new tab.
3. The new tab will immediately close.
4. Apply the patch.
5. Perform steps 1-2 again.
6. The tab should now remain open.
Sponsored-by: Gothenburg University Library
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
| koha-tmpl/intranet-tmpl/prog/en/includes/str/cataloging_additem.inc | diffblobblamehistory |