| commit | 9c8cbd3dc10860012a5bc55fd7dad4d3fc1041cd | |
| author | Jonathan Druart <jonathan.druart@biblibre.com> | |
| Thu, 16 Apr 2015 12:10:30 +0000 (16 14:10 +0200) | ||
| committer | Chris Cormack <chrisc@catalyst.net.nz> | |
| Mon, 11 May 2015 22:18:52 +0000 (12 10:18 +1200) | ||
| tree | bd86e28b1a3a93d64ea56d535d60107d205c3929 | treesnapshot (tar.gz zip) |
| parent | 23a326b1f67b0f3a51ce45c6241469022d856924 | commitdiff |
Bug 13482: Prevent race condition on printing a ReserveSlip
The problem has been well described by Kyle and Nicole on bug 7255
description and comment 1.
With this counter patch, I suggest to popup AFTER the return has been
confirmed. This will remove the race condition and avoid to pass
itemnumber to the pl file as in the patch submitted by Olli.
Only the borrowernumber and biblionumber are needed (transfer and op are
never used by circ/hold-transfer-slip.pl).
Test plan:
It is very hard to know all cases (at least 6) where the popup is
displayed. Try at least to get the hold and the transfer confirmation
messages.
You should get the popup if you click on "print slip" button.
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 2796eb21586ea7f23c2ca5d969d242b78b1cfa09)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
The problem has been well described by Kyle and Nicole on bug 7255
description and comment 1.
With this counter patch, I suggest to popup AFTER the return has been
confirmed. This will remove the race condition and avoid to pass
itemnumber to the pl file as in the patch submitted by Olli.
Only the borrowernumber and biblionumber are needed (transfer and op are
never used by circ/hold-transfer-slip.pl).
Test plan:
It is very hard to know all cases (at least 6) where the popup is
displayed. Try at least to get the hold and the transfer confirmation
messages.
You should get the popup if you click on "print slip" button.
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 2796eb21586ea7f23c2ca5d969d242b78b1cfa09)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
| circ/hold-transfer-slip.pl | diffblobblamehistory | |
| circ/returns.pl | diffblobblamehistory | |
| koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | diffblobblamehistory |