| commit | 99dd6efa9fb2b5cf24929cb1f8019ad334d7dc83 | |
| author | Jonathan Druart <jonathan.druart@bugs.koha-community.org> | |
| Wed, 6 Dec 2017 16:03:15 +0000 (6 13:03 -0300) | ||
| committer | Nick Clemens <nick@bywatersolutions.com> | |
| Wed, 20 Dec 2017 11:56:36 +0000 (20 11:56 +0000) | ||
| tree | c9ea630fc2d90a13322f632f8028a0fadc2ae073 | treesnapshot (tar.gz zip) |
| parent | 13c02b84e6df4d180865d4f80bee271fdd2cd858 | commitdiff |
Bug 19759: Make TestBuilder generates only 2 decimals for float
For instance items.replacementprice is decimal(8,2) but more than 2 decimals are generated.
It leads to issues when we compare expected objects:
# got: '135623.866142537'
# expected: '135623.87'
Test plan:
prove t/db_dependent/TestBuilder.t
must return green
Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Somehow I have the feeling that we should allow more decimals sometimes
and perhaps have a number of decimals parameter or so. Think of fields
like currency or discount.
But the current issues justify this change.
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
For instance items.replacementprice is decimal(8,2) but more than 2 decimals are generated.
It leads to issues when we compare expected objects:
# got: '135623.866142537'
# expected: '135623.87'
Test plan:
prove t/db_dependent/TestBuilder.t
must return green
Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Somehow I have the feeling that we should allow more decimals sometimes
and perhaps have a number of decimals parameter or so. Think of fields
like currency or discount.
But the current issues justify this change.
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
| t/db_dependent/TestBuilder.t | diffblobblamehistory | |
| t/lib/TestBuilder.pm | diffblobblamehistory |