| commit | 8ebffcdb106d46c9f8b1877a086407ecfb1cbae1 | |
| author | Jonathan Druart <jonathan.druart@bugs.koha-community.org> | |
| Fri, 14 Oct 2016 13:26:58 +0000 (14 14:26 +0100) | ||
| committer | Kyle M Hall <kyle@bywatersolutions.com> | |
| Fri, 21 Oct 2016 17:15:25 +0000 (21 17:15 +0000) | ||
| tree | dee8baca3baeddc38d05893089311e1e72ca999e | treesnapshot (tar.gz zip) |
| parent | 038ad70fb31b787509c30c6499f3fab77356005a | commitdiff |
Bug 17445: Move the params check after the authentication check
If the user is not authorised to call this route, we would prefer to
raise a 403 instead of 400
Note that we wanted to submit tests for this change but the city code
does not let use do that (we are allowed to list/show cities even
without any permissions). The patrons.t is not complete enought and the
holds.t tests do not pass...
Tomas plans to submit tests but we reach the end of the hackfest ;)
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
If the user is not authorised to call this route, we would prefer to
raise a 403 instead of 400
Note that we wanted to submit tests for this change but the city code
does not let use do that (we are allowed to list/show cities even
without any permissions). The patrons.t is not complete enought and the
holds.t tests do not pass...
Tomas plans to submit tests but we reach the end of the hackfest ;)
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
| Koha/REST/V1.pm | diffblobblamehistory |