| commit | 563a25d952ee571eb1d626f97eef001c5f646b1f | |
| author | Jonathan Druart <jonathan.druart@bugs.koha-community.org> | |
| Thu, 6 Jun 2019 20:14:28 +0000 (6 15:14 -0500) | ||
| committer | Jonathan Druart <jonathan.druart@bugs.koha-community.org> | |
| Mon, 20 Jul 2020 14:16:37 +0000 (20 16:16 +0200) | ||
| tree | d9f7e9eb849113f51be92ca35a3e3113860a5544 | treesnapshot (tar.gz zip) |
| parent | 2fb5f3624ee87ab8179909a4ad80b1aba76becc0 | commitdiff |
Bug 23070: Use Koha::Hold in C4::Reserves::RevertWaitingStatus
We are using raw SQL statements, we should use Koha::Hold instead.
This patch does not seem optimal, we would like to increment priority in
only 1 statement and without the need to fetch and loop all holds.
== Test plan ==
- apply patch
- place some holds on the same record
- check that the priorities look good
- mark one hold as waiting by doing a check-in
- revert the waiting status
- confirm that the priorities are recalculated correctly
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
We are using raw SQL statements, we should use Koha::Hold instead.
This patch does not seem optimal, we would like to increment priority in
only 1 statement and without the need to fetch and loop all holds.
== Test plan ==
- apply patch
- place some holds on the same record
- check that the priorities look good
- mark one hold as waiting by doing a check-in
- revert the waiting status
- confirm that the priorities are recalculated correctly
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
| C4/Reserves.pm | diffblobblamehistory |