Bug 25147: AllowSelfCheckReturns is in the wrong system preference section
commit4e9a8b6413a0ce64e5757842a61ed122d8fe8d15
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 17 Apr 2020 06:51:16 +0000 (17 07:51 +0100)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 17 Apr 2020 07:22:43 +0000 (17 08:22 +0100)
treede693307b596f3c360bfbbe6a5a5d4ce993bef59
parent8aa9f2cc078932a0a4db434f8bd793de29a8ff7b
Bug 25147: AllowSelfCheckReturns is in the wrong system preference section

This reverts commit 8aa9f2cc078932a0a4db434f8bd793de29a8ff7b.

I agree with the following comment and as such have reverted the patch.

Quoting Phil Ringnalda <phil@chetcolibrary.org>:

  Everything currently in the chunk labelled "Self Checkout" is
  preferences used to control sco-main.pl, a feature that does checkout
  and renewal, and optionally with the preference AllSelfCheckReturns,
  also checkin.

  Everything currently in the chunk labelled "Self check-in module" is
  preferences used to control sci-main.pl, a separate feature that does
  only checkin, and does checkin whether or not AllowSelfCheckReturns is
  set.

  I'd think a better solution would be to either rename the preference,
  which is actually AllowReturnsInSelfCheckout, or rename the chunks to
  make it more clear that they are preferences for two different features.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref