| commit | 268f03d34b370633a801142a62525bf8ca53c520 | |
| author | Jonathan Druart <jonathan.druart@bugs.koha-community.org> | |
| Thu, 30 Jan 2020 14:38:26 +0000 (30 15:38 +0100) | ||
| committer | Martin Renvoize <martin.renvoize@ptfs-europe.com> | |
| Fri, 31 Jan 2020 13:55:55 +0000 (31 13:55 +0000) | ||
| tree | 83dfe4ca29d0050340e997e0243ffcd405fd43ed | treesnapshot (tar.gz zip) |
| parent | 82c8542cb6493c9d2ddc9a1f26c54d6aac675317 | commitdiff |
Bug 24546: Fix intentions of build_sample_item in Club/Hold.t
In t/db_dependent/Koha/Club/Hold.t:
my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode });
my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode });
build_sample_item takes either "library" or the item's attributes.
branchcode is not part of the item's table, so what those 2 lines are trying to acchieve is wrong.
Test plan:
% prove t/db_dependent/Koha/Club/Hold.t
must return green before and after this patch
Note that this patch also remove an uneeded debugging statement.
This has been caught by bug 24363.
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
In t/db_dependent/Koha/Club/Hold.t:
my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode });
my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode });
build_sample_item takes either "library" or the item's attributes.
branchcode is not part of the item's table, so what those 2 lines are trying to acchieve is wrong.
Test plan:
% prove t/db_dependent/Koha/Club/Hold.t
must return green before and after this patch
Note that this patch also remove an uneeded debugging statement.
This has been caught by bug 24363.
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
| t/db_dependent/Koha/Club/Hold.t | diffblobblamehistory |