| commit | 1069bc240525f72d1e06bb9b78ef55fbec6dad2e | |
| author | Martin Renvoize <martin.renvoize@ptfs-europe.com> | |
| Wed, 29 Jan 2020 13:18:20 +0000 (29 13:18 +0000) | ||
| committer | Martin Renvoize <martin.renvoize@ptfs-europe.com> | |
| Wed, 5 Feb 2020 12:38:25 +0000 (5 12:38 +0000) | ||
| tree | 8ee1b279dc4c7790c9ed492a815cd7d58b0e9c33 | treesnapshot (tar.gz zip) |
| parent | d88dfbf34e68849e0deed5543817decf6dfb19cb | commitdiff |
Bug 24529: Silence warnings for title level holds
This patch simply adds a test for itemnumber being defined in the
reserve before comparing it to silence the warning.
Test plan:
1) Prior to patch, run prove t/db_dependant/Circulation.t and note lots
of `Use of uninitialized value in numeric eq (==) at
/kohadevbox/koha/C4/Reserves.pm line 790` warnings.
2) Apply the patch, re-run the test and note the tests still pass but
the warnings are now gone.
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This patch simply adds a test for itemnumber being defined in the
reserve before comparing it to silence the warning.
Test plan:
1) Prior to patch, run prove t/db_dependant/Circulation.t and note lots
of `Use of uninitialized value in numeric eq (==) at
/kohadevbox/koha/C4/Reserves.pm line 790` warnings.
2) Apply the patch, re-run the test and note the tests still pass but
the warnings are now gone.
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
| C4/Reserves.pm | diffblobblamehistory |