| commit | 25057ccba1448a2a8bf1508d34793de07fe339a0 | |
| author | Johannes Sixt <j6t@kdbg.org> | |
| Sun, 4 Nov 2012 20:32:08 +0000 (4 21:32 +0100) | ||
| committer | Johannes Sixt <j6t@kdbg.org> | |
| Sun, 4 Nov 2012 20:40:02 +0000 (4 21:40 +0100) | ||
| tree | 6b014469949252454b41df8ccb8085dc50ae7343 | treesnapshot (tar.gz zip) |
| parent | c15d7a92dad52ac9d7023b8ea2717103a7293903 | commitdiff |
Fix skipping an error message in parseBreakpoint().
The function receives the string to parse in variable 'output'. Its value
is copied to a local variable 'o', which is used to skip past an error
message. But later, variable 'output' is used.
This bug is present since day one, and not even the refactorings that
happened in 36acbde5 (Created an abstract base class DebuggerDriver, which
moved the function from brkpt.cpp to gdbdriver.cpp) and 261a7a51 (Fixed
watchpoints, which split off function parseNewBreakpoint()) did anything to
fix the bug. Fix it now.
The function receives the string to parse in variable 'output'. Its value
is copied to a local variable 'o', which is used to skip past an error
message. But later, variable 'output' is used.
This bug is present since day one, and not even the refactorings that
happened in 36acbde5 (Created an abstract base class DebuggerDriver, which
moved the function from brkpt.cpp to gdbdriver.cpp) and 261a7a51 (Fixed
watchpoints, which split off function parseNewBreakpoint()) did anything to
fix the bug. Fix it now.
| kdbg/gdbdriver.cpp | diffblobblamehistory |