| commit | e4de8b4626f8872a4cb1ee241b60902653567503 | |
| author | Michał Gołębiowski-Owczarek <m.goleb@gmail.com> | |
| Mon, 21 Jan 2019 17:34:40 +0000 (21 18:34 +0100) | ||
| committer | GitHub <noreply@github.com> | |
| Mon, 21 Jan 2019 17:34:40 +0000 (21 18:34 +0100) | ||
| tree | b5a7707bc09e0198cfff9b9919a0a1e4fb7a5370 | treesnapshot (tar.gz zip) |
| parent | 543d3d24eaefe09c4012171f30267783d51602dc | commitdiff |
Manipulation: Respect script nomodule attribute in DOM manipulation
PR #3869 added support for `<script type="module">` & some support for
the `nomodule` attribute but with no tests for `nomodule` and with the
attribute only respected on inline scripts. This commit adds support for
source-based scripts as well. It also adds tests for `nomodule`, including
making sure legacy browsers execute such scripts as they'd natively do - that's
the whole point of `nomodule` scripts, after all.
Fixes gh-4281
Closes gh-4282
Ref gh-3871
Ref gh-3869
PR #3869 added support for `<script type="module">` & some support for
the `nomodule` attribute but with no tests for `nomodule` and with the
attribute only respected on inline scripts. This commit adds support for
source-based scripts as well. It also adds tests for `nomodule`, including
making sure legacy browsers execute such scripts as they'd natively do - that's
the whole point of `nomodule` scripts, after all.
Fixes gh-4281
Closes gh-4282
Ref gh-3871
Ref gh-3869
| src/manipulation.js | diffblobblamehistory | |
| test/data/inner_nomodule.js | [new file with mode: 0644] | blob |
| test/data/nomodule.js | [new file with mode: 0644] | blob |
| test/unit/manipulation.js | diffblobblamehistory |