| commit | 1ad66aeb6d7d94f8e4c8e2286569722ca41f9868 | |
| author | Michał Gołębiowski-Owczarek <m.goleb@gmail.com> | |
| Mon, 16 Oct 2023 16:54:54 +0000 (16 18:54 +0200) | ||
| committer | GitHub <noreply@github.com> | |
| Mon, 16 Oct 2023 16:54:54 +0000 (16 18:54 +0200) | ||
| tree | 76f624d16cf15d5c58c90f9a6e11d13f98f9c5c7 | treesnapshot (tar.gz zip) |
| parent | ace646f6e83e653f666ba715c200739f1cbdba52 | commitdiff |
Build: Run pretest before test:* npm scripts
Build was already happening in scripts like `test:browser` but those scripts
were missing `pretest`, meaning that running `npm install && npm test:browser`
may have failed if `pretest` wasn't run before or if its results were out of
date.
Even worse, with such stale data some tests may erroneously succeed.
This also removes a separate `pretest` step from GitHub Actions as it's no
longer needed.
Closes gh-5338
Build was already happening in scripts like `test:browser` but those scripts
were missing `pretest`, meaning that running `npm install && npm test:browser`
may have failed if `pretest` wasn't run before or if its results were out of
date.
Even worse, with such stale data some tests may erroneously succeed.
This also removes a separate `pretest` step from GitHub Actions as it's no
longer needed.
Closes gh-5338
| .github/workflows/node.js.yml | diffblobblamehistory | |
| package.json | diffblobblamehistory |