From 2c9a0f4391afa3a6a73f49d046b3c63c0b4b0ce8 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jan=20Kundr=C3=A1t?= Date: Sun, 5 Oct 2008 23:10:56 +0200 Subject: [PATCH] use field names instead of * in the SELECT statement --- src/core/CollectionModel.cpp | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/core/CollectionModel.cpp b/src/core/CollectionModel.cpp index ca4b1c8..d0ed45a 100644 --- a/src/core/CollectionModel.cpp +++ b/src/core/CollectionModel.cpp @@ -64,7 +64,8 @@ namespace Jerboa plainText << "URI\tAlbum\tAlbumArtist\tArtist\tTitle\tTrackNumber"; SqlQuery query(mDB); - query.prepare("SELECT * FROM TrackData WHERE ID = :id LIMIT 1"); + query.prepare("SELECT FileName, Album, AlbumArtist, AlbumArtistRomanised, Artist, ArtistRomanised, " + "Title, TrackNumber, AlbumRG, TrackRG, MBID FROM TrackData WHERE ID = :id LIMIT 1"); Q_FOREACH(QModelIndex index, indexes) { if ( ! index.isValid() ) return ret; @@ -77,18 +78,18 @@ namespace Jerboa QSqlRecord r = query.record(); - QUrl uri = QUrl::fromLocalFile(r.value(1).toString()); + QUrl uri = QUrl::fromLocalFile(r.value(0).toString()); QString uriString = uri.toEncoded(); - QString album = r.value(2).toString(); - QString albumArtist = r.value(3).toString(); - QString albumArtistRomanised = r.value(4).toString(); - QString artist = r.value(5).toString(); - QString artistRomanised = r.value(6).toString(); - QString title = r.value(7).toString(); - QString trackNumber = r.value(8).toString(); - QString albumRG = r.value(9).toString(); - QString trackRG = r.value(10).toString(); - QString mbid = r.value(11).toString(); + QString album = r.value(1).toString(); + QString albumArtist = r.value(2).toString(); + QString albumArtistRomanised = r.value(3).toString(); + QString artist = r.value(4).toString(); + QString artistRomanised = r.value(5).toString(); + QString title = r.value(6).toString(); + QString trackNumber = r.value(7).toString(); + QString albumRG = r.value(8).toString(); + QString trackRG = r.value(9).toString(); + QString mbid = r.value(10).toString(); uris << uri; QStringList plainTextFields; -- 2.11.4.GIT