ReceivePack: Clarify the check reachable option
commit585dcb7a1ce7fd9e9cbd8f61f8bc6ab9afcb329c
authorShawn O. Pearce <spearce@spearce.org>
Sat, 17 Apr 2010 00:03:54 +0000 (16 17:03 -0700)
committerShawn O. Pearce <spearce@spearce.org>
Sat, 17 Apr 2010 00:04:38 +0000 (16 17:04 -0700)
tree111f1d77e0ae098907b150e0dbfc13811b056275
parenta770205070b52199e5c561f407ee0b0168dd8b9f
ReceivePack: Clarify the check reachable option

This option was mis-named from day 1.  Its not checking that the
objects provided by the client are reachable, its actually doing
a scan to prove that objects referenced by the client are already
reachable through another reference on the server, or were sent
as part of the pack from the client.

Rename it checkReferencedObjectsAreReachable, since we really are
trying to validate that objects referenced by the client's actions
are reachable to the client.

We also need to ensure we run checkConnectivity() anytime this is
enabled, even if the caller didn't turn on fsck for object formats.
Otherwise the check would be completely bypassed.

Change-Id: Ic352ddb0ca8464d407c6da5c83573093e018af19
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
org.eclipse.jgit.test/tst/org/eclipse/jgit/transport/ReceivePackRefFilterTest.java
org.eclipse.jgit/src/org/eclipse/jgit/transport/ReceivePack.java