| commit | efdcb16be3d34e97bb05d9ddaea538ba2d906eca | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Tue, 9 Feb 2010 23:58:37 +0000 (9 15:58 -0800) | ||
| committer | Shawn O. Pearce <spearce@spearce.org> | |
| Wed, 10 Feb 2010 03:51:36 +0000 (9 19:51 -0800) | ||
| tree | c0c1aa5b4762b7e512e6d428f534be2b5ab23f36 | treesnapshot (tar.gz zip) |
| parent | 3dd067042f60cabe970b0f5bc05d13988c93ddb3 | commitdiff |
Remove pointless boolean during native push
The boolean field sentCommand is always true at this point, as it
was assigned just 5 lines above. So we always set the status of
the update command object to AWAITING_REPORT.
Simplify the logic by dropping the ?: operator. I assume this is
older code from an attempt to manage dry-run push support within
the native connection, but in fact dry-run support is done higher
up inside of PushProcess.
Change-Id: I450d491bbbb5afecdbf5444ab7169222e856a3bb
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
The boolean field sentCommand is always true at this point, as it
was assigned just 5 lines above. So we always set the status of
the update command object to AWAITING_REPORT.
Simplify the logic by dropping the ?: operator. I assume this is
older code from an attempt to manage dry-run push support within
the native connection, but in fact dry-run support is done higher
up inside of PushProcess.
Change-Id: I450d491bbbb5afecdbf5444ab7169222e856a3bb
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
| org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java | diffblobblamehistory |