| commit | dd931bd9785661ac4145b3625b94e9f23c29cb03 | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Thu, 11 Feb 2010 19:39:09 +0000 (11 11:39 -0800) | ||
| committer | Shawn O. Pearce <spearce@spearce.org> | |
| Thu, 11 Feb 2010 19:44:37 +0000 (11 11:44 -0800) | ||
| tree | 9d722491e5563d66cba9d11c84fa1ed0f1656858 | treesnapshot (tar.gz zip) |
| parent | e54d33b6873f0b392640f9200398861210ac9374 | commitdiff |
Don't doubly wrap TransportException in smart HTTP client
If the readAdvertisedRefs() method throws an exception, its already
closed the connection and wrapped the underlying cause inside of a
suitable TransportException object that it is throwing. We shouldn't
catch IOException and rethrow a wrapped copy here, because we'll double
wrap the exception thrown by readAdvertisedRefs. This may obsecure the
root cause of the connection failure from the end-user.
Change-Id: I0ca61560f9888c666323dac8a5582aab25e897ff
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
If the readAdvertisedRefs() method throws an exception, its already
closed the connection and wrapped the underlying cause inside of a
suitable TransportException object that it is throwing. We shouldn't
catch IOException and rethrow a wrapped copy here, because we'll double
wrap the exception thrown by readAdvertisedRefs. This may obsecure the
root cause of the connection failure from the end-user.
Change-Id: I0ca61560f9888c666323dac8a5582aab25e897ff
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
| org.eclipse.jgit/src/org/eclipse/jgit/transport/TransportHttp.java | diffblobblamehistory |