| commit | 655ff5e4e199a11535c5957653322d1f2f0dc446 | |
| author | Florian Walpen <dev@submerge.ch> | |
| Thu, 23 Dec 2021 12:40:39 +0000 (23 13:40 +0100) | ||
| committer | falkTX <falktx@falktx.com> | |
| Sat, 15 Jan 2022 15:09:55 +0000 (15 15:09 +0000) | ||
| tree | ccc3077d04aad418e5df99aaa1a28ea3d2892a3c | treesnapshot (tar.gz zip) |
| parent | b5597128c25aae3423683c101e72f0ff8107ec3d | commitdiff |
POSIX: Remove unnecessary feature test macro.
This is a no-op since the line was already commented out, to make it
compile on FreeBSD. But it deserves an explanation:
The _POSIX_C_SOURCE macro is meant to restrict the C library to a
certain POSIX standard, not to enable features. This is inappropriate
here because:
1. Jack already uses non-POSIX functions. E.g. JackPosixSemaphore.cpp
references gettimeofday(), which is part of the X/Open specs.
2. C++ does not define a POSIX level to be based on. Headers from the
C++ standard library may (and do) break when the POSIX feature level
is restricted.
The canonical way is to only set the feature level through the
"--std=gnu++11" compile options.
This is a no-op since the line was already commented out, to make it
compile on FreeBSD. But it deserves an explanation:
The _POSIX_C_SOURCE macro is meant to restrict the C library to a
certain POSIX standard, not to enable features. This is inappropriate
here because:
1. Jack already uses non-POSIX functions. E.g. JackPosixSemaphore.cpp
references gettimeofday(), which is part of the X/Open specs.
2. C++ does not define a POSIX level to be based on. Headers from the
C++ standard library may (and do) break when the POSIX feature level
is restricted.
The canonical way is to only set the feature level through the
"--std=gnu++11" compile options.
| posix/JackPosixSemaphore.cpp | diffblobblamehistory |