From c0850f8a7f688fa982606fd713e04ccebf59fba5 Mon Sep 17 00:00:00 2001 From: Sven Verdoolaege Date: Tue, 2 Jun 2015 10:33:36 +0200 Subject: [PATCH] isl_aff_move_dims: add missing returns on error paths Reported-by: Andreas Kloeckner Signed-off-by: Sven Verdoolaege --- isl_aff.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/isl_aff.c b/isl_aff.c index ec9c56df..96274ed0 100644 --- a/isl_aff.c +++ b/isl_aff.c @@ -2414,10 +2414,11 @@ __isl_give isl_aff *isl_aff_move_dims(__isl_take isl_aff *aff, if (dst_type == isl_dim_out || src_type == isl_dim_out) isl_die(isl_aff_get_ctx(aff), isl_error_invalid, - "cannot move output/set dimension", isl_aff_free(aff)); + "cannot move output/set dimension", + return isl_aff_free(aff)); if (dst_type == isl_dim_div || src_type == isl_dim_div) isl_die(isl_aff_get_ctx(aff), isl_error_invalid, - "cannot move divs", isl_aff_free(aff)); + "cannot move divs", return isl_aff_free(aff)); if (dst_type == isl_dim_in) dst_type = isl_dim_set; if (src_type == isl_dim_in) @@ -2425,11 +2426,11 @@ __isl_give isl_aff *isl_aff_move_dims(__isl_take isl_aff *aff, if (src_pos + n > isl_local_space_dim(aff->ls, src_type)) isl_die(isl_aff_get_ctx(aff), isl_error_invalid, - "range out of bounds", isl_aff_free(aff)); + "range out of bounds", return isl_aff_free(aff)); if (dst_type == src_type) isl_die(isl_aff_get_ctx(aff), isl_error_unsupported, "moving dims within the same type not supported", - isl_aff_free(aff)); + return isl_aff_free(aff)); aff = isl_aff_cow(aff); if (!aff) -- 2.11.4.GIT