| commit | 179e221bbd892f327cfb7ba3ed408ae695d604aa | |
| author | Sven Verdoolaege <sven.verdoolaege@gmail.com> | |
| Fri, 5 Oct 2018 16:05:21 +0000 (5 18:05 +0200) | ||
| committer | Sven Verdoolaege <sven.verdoolaege@gmail.com> | |
| Fri, 5 Oct 2018 16:07:32 +0000 (5 18:07 +0200) | ||
| tree | 99aa91106ca8130574801698442b2bcbc41bf198 | treesnapshot (tar.gz zip) |
| parent | 2c183b79d8de1fa4e648ecfd7e1eea9076825429 | commitdiff |
isl_basic_map_reduce_coefficients: drop no-redundant flag on tightening
If isl_basic_map_reduce_coefficients tightens any constraint,
then the result can no longer be assumed to have
no redundant constraints.
Not clearing the flag can cause problems during coalescing
as the internals assume that all redundant constraints
are explicitly marked, but the procedure will only check
for redundant constraints if the flag is not set.
In particular, relaxing a redundant constraint is not allowed,
while a constraint that is not initially marked as redundant
but gets marked as such along the way may end up being considered
for relaxation, as in the new test case.
Reported-by: Tobias Grosser <tobias.grosser@inf.ethz.ch>
Signed-off-by: Sven Verdoolaege <sven.verdoolaege@gmail.com>
If isl_basic_map_reduce_coefficients tightens any constraint,
then the result can no longer be assumed to have
no redundant constraints.
Not clearing the flag can cause problems during coalescing
as the internals assume that all redundant constraints
are explicitly marked, but the procedure will only check
for redundant constraints if the flag is not set.
In particular, relaxing a redundant constraint is not allowed,
while a constraint that is not initially marked as redundant
but gets marked as such along the way may end up being considered
for relaxation, as in the new test case.
Reported-by: Tobias Grosser <tobias.grosser@inf.ethz.ch>
Signed-off-by: Sven Verdoolaege <sven.verdoolaege@gmail.com>
| isl_map_simplify.c | diffblobblamehistory | |
| isl_test.c | diffblobblamehistory |