From 2cf749481ab62b6f2e7a25e42c1870d102ce112c Mon Sep 17 00:00:00 2001 From: =?utf8?q?David=20H=C3=B6ppner?= <0xffea@gmail.com> Date: Sun, 1 Mar 2015 12:40:06 +0000 Subject: [PATCH] 1150 libcmdutils has superfluous #define Reviewed by: Josef 'Jeff' Sipek Reviewed by: Andy Stormont Reviewed by: Marcel Telka Approved by: Dan McDonald --- usr/src/lib/libcmdutils/common/writefile.c | 14 ++++++-------- usr/src/lib/libcmdutils/libcmdutils.h | 1 - 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/usr/src/lib/libcmdutils/common/writefile.c b/usr/src/lib/libcmdutils/common/writefile.c index 750974c581..84cdb78d60 100644 --- a/usr/src/lib/libcmdutils/common/writefile.c +++ b/usr/src/lib/libcmdutils/common/writefile.c @@ -37,8 +37,6 @@ * contributors. */ -#pragma ident "%Z%%M% %I% %E% SMI" - #include "libcmdutils.h" @@ -98,7 +96,7 @@ writefile(int fi, int fo, char *infile, char *outfile, char *asfile, (void) snprintf(targbuf, targ_size, "%s", outfile); } - if (ISREG(*s1p) && s1p->st_size > SMALLFILESIZE) { + if (S_ISREG(s1p->st_mode) && s1p->st_size > SMALLFILESIZE) { /* * Determine size of initial mapping. This will determine the * size of the address space chunk we work with. This initial @@ -140,7 +138,7 @@ writefile(int fi, int fo, char *infile, char *outfile, char *asfile, (void) close(fi); (void) close(fo); (void) munmap(cp, munmapsize); - if (ISREG(*s2p)) + if (S_ISREG(s2p->st_mode)) (void) unlink(targbuf); return (1); } @@ -164,7 +162,7 @@ writefile(int fi, int fo, char *infile, char *outfile, char *asfile, (void) close(fi); (void) close(fo); (void) munmap(cp, munmapsize); - if (ISREG(*s2p)) + if (S_ISREG(s2p->st_mode)) (void) unlink(targbuf); if (srcbuf != NULL) free(srcbuf); @@ -184,7 +182,7 @@ writefile(int fi, int fo, char *infile, char *outfile, char *asfile, (void) close(fi); (void) close(fo); (void) munmap(cp, munmapsize); - if (ISREG(*s2p)) + if (S_ISREG(s2p->st_mode)) (void) unlink(targbuf); if (srcbuf != NULL) free(srcbuf); @@ -203,7 +201,7 @@ writefile(int fi, int fo, char *infile, char *outfile, char *asfile, } else if (n < 0) { (void) close(fi); (void) close(fo); - if (ISREG(*s2p)) + if (S_ISREG(s2p->st_mode)) (void) unlink(targbuf); if (srcbuf != NULL) free(srcbuf); @@ -213,7 +211,7 @@ writefile(int fi, int fo, char *infile, char *outfile, char *asfile, } else if (write(fo, buf, n) != n) { (void) close(fi); (void) close(fo); - if (ISREG(*s2p)) + if (S_ISREG(s2p->st_mode)) (void) unlink(targbuf); if (srcbuf != NULL) free(srcbuf); diff --git a/usr/src/lib/libcmdutils/libcmdutils.h b/usr/src/lib/libcmdutils/libcmdutils.h index a280751c27..bbc03475dc 100644 --- a/usr/src/lib/libcmdutils/libcmdutils.h +++ b/usr/src/lib/libcmdutils/libcmdutils.h @@ -68,7 +68,6 @@ extern "C" { #define MAXMAPSIZE (1024*1024*8) /* map at most 8MB */ #define SMALLFILESIZE (32*1024) /* don't use mmap on little file */ -#define ISREG(A) (((A).st_mode & S_IFMT) == S_IFREG) /* avltree */ #define OFFSETOF(s, m) ((size_t)(&(((s *)0)->m))) -- 2.11.4.GIT