From f7319526b045379eff7974536f6ea44c0406f750 Mon Sep 17 00:00:00 2001 From: Lucian Wischik Date: Tue, 9 Jun 2020 22:12:26 -0700 Subject: [PATCH] clarify check kind in logs Summary: Lots of people read the word "Full_check" in the logs and think it's doing a full init. That's not the case. Reviewed By: CatherineGasnier Differential Revision: D21883059 fbshipit-source-id: f47ec1f773b613e4a2f64084230f4b1648cdc695 --- hphp/hack/src/server/serverTypeCheck.ml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hphp/hack/src/server/serverTypeCheck.ml b/hphp/hack/src/server/serverTypeCheck.ml index 0ff7c0f6002..4e9b91a6ce9 100644 --- a/hphp/hack/src/server/serverTypeCheck.ml +++ b/hphp/hack/src/server/serverTypeCheck.ml @@ -1455,8 +1455,10 @@ functor end let check_kind_to_string = function - | Full_check -> "Full_check" - | Lazy_check -> "Lazy_check" + | Full_check -> + "will bring hh_server to consistency with code changes, by checking whatever fanout is needed ('Full_check')" + | Lazy_check -> + "will check only those files already open in IDE or with reported errors ('Lazy_check')" module FC = Make (FullCheckKind) module LC = Make (LazyCheckKind) -- 2.11.4.GIT