From f365079033794e0177fb74396125d3c7cc2287e3 Mon Sep 17 00:00:00 2001
From: Vassil Mladenov <vmladenov@meta.com>
Date: Mon, 6 Feb 2023 16:30:12 -0800
Subject: [PATCH] Redirect pessimisation logs to Hh_logger if level > 1

Summary:
Same as D43014949 but for pessimise logs.

An alternative implementation for this stack could be to redirect to Hh_logger if `pessimise.hh` or `tany.hh` is set, but neither flag actually uses more than level 1 at the moment so this is fine.

Reviewed By: periodic1236

Differential Revision: D43017410

fbshipit-source-id: 3c45858188d9ce7c8aca91a14518b9b88d786700
---
 hphp/hack/src/typing/typing_log.ml | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/hphp/hack/src/typing/typing_log.ml b/hphp/hack/src/typing/typing_log.ml
index b21fbf46cbf..5ee9b9e5bcf 100644
--- a/hphp/hack/src/typing/typing_log.ml
+++ b/hphp/hack/src/typing/typing_log.ml
@@ -764,15 +764,20 @@ let log_localize ~level ety_env (decl_ty : decl_ty) (env, result_ty) =
   (env, result_ty)
 
 let log_pessimise_ ?(level = 1) env kind pos name =
-  log_with_level env "pessimise" ~level @@ fun () ->
-  let p = Pos_or_decl.unsafe_to_raw_pos pos in
-  let (file, line) =
-    let p = Pos.to_absolute p in
-    (Pos.filename p, Pos.line p)
-  in
-  lnewline ();
-  lprintf (Normal Yellow) "pessimise:\t%s,%s,%d,%s" kind file line name;
-  lnewline ()
+  let log_level = Typing_env_types.get_log_level env "pessimise" in
+  if log_level >= level then
+    let p = Pos_or_decl.unsafe_to_raw_pos pos in
+    let (file, line) =
+      let p = Pos.to_absolute p in
+      (Pos.filename p, Pos.line p)
+    in
+    if log_level > 1 then
+      Hh_logger.log "pessimise:\t%s,%s,%d,%s" kind file line name
+    else (
+      lnewline ();
+      lprintf (Normal Yellow) "pessimise:\t%s,%s,%d,%s" kind file line name;
+      lnewline ()
+    )
 
 let log_pessimise_prop env pos prop_name =
   log_pessimise_ env "prop" (Pos_or_decl.of_raw_pos pos) ("$" ^ prop_name)
-- 
2.11.4.GIT