From e8e75084d9b041273d7ecc819d3195c2291afad3 Mon Sep 17 00:00:00 2001 From: Millie Chen Date: Fri, 28 Feb 2020 17:57:48 -0800 Subject: [PATCH] Fix bug in emit_while Summary: Missed an `emit_jmpnz` Reviewed By: shiqicao Differential Revision: D20167564 fbshipit-source-id: d779ae6365e03f3b8d012b46184c2a1c5a9edd49 --- hphp/hack/src/hhbc/emit_statement.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/hphp/hack/src/hhbc/emit_statement.rs b/hphp/hack/src/hhbc/emit_statement.rs index 6bc4e982b68..cbb41ebb44f 100644 --- a/hphp/hack/src/hhbc/emit_statement.rs +++ b/hphp/hack/src/hhbc/emit_statement.rs @@ -382,6 +382,7 @@ fn emit_while(e: &mut Emitter, env: &mut Env, cond: &tast::Expr, body: &tast::St emit_stmt_wrapper, )?, InstrSeq::make_label(cont_label), + emit_expr::emit_jmpnz(e, env, cond, &start_label)?.instrs, InstrSeq::make_label(break_label), ])) } -- 2.11.4.GIT