From 9dabfb9abc997254cea0e2ceb0ea9196a6991f44 Mon Sep 17 00:00:00 2001
From: Lucian Wischik <ljw@fb.com>
Date: Wed, 24 Nov 2021 08:24:27 -0800
Subject: [PATCH] log every compute_tast

Reviewed By: CatherineGasnier

Differential Revision: D32632046

fbshipit-source-id: fd7509a6acfad14af4306c70a273f19953e9ecd6
---
 hphp/hack/src/providers/tast_provider.ml       | 7 ++++---
 hphp/hack/src/stubs/logging/hackEventLogger.ml | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/hphp/hack/src/providers/tast_provider.ml b/hphp/hack/src/providers/tast_provider.ml
index 8751910ffab..bdd166285e1 100644
--- a/hphp/hack/src/providers/tast_provider.ml
+++ b/hphp/hack/src/providers/tast_provider.ml
@@ -54,7 +54,7 @@ let compute_tast_and_errors_unquarantined_internal
     let prev_gc_telemetry = Telemetry.quick_gc_stat () in
     Decl_counters.set_mode Typing_service_types.DeclingTopCounts;
     let prev_tally_state = Counters.reset () in
-    let t = Unix.gettimeofday () in
+    let start_time = Unix.gettimeofday () in
 
     (* do the work *)
     let ({ Parser_return.ast; content; _ }, ast_errors) =
@@ -119,7 +119,7 @@ let compute_tast_and_errors_unquarantined_internal
       |> Telemetry.int_ ~key:"errors.tast" ~value:(Errors.count typing_errors)
       |> Telemetry.float_
            ~key:"duration_decl_and_typecheck"
-           ~value:(Unix.gettimeofday () -. t)
+           ~value:(Unix.gettimeofday () -. start_time)
       |> Telemetry.int_
            ~key:"filesize"
            ~value:
@@ -134,7 +134,8 @@ let compute_tast_and_errors_unquarantined_internal
       (Telemetry.to_string telemetry);
     HackEventLogger.ProfileTypeCheck.compute_tast
       ~telemetry
-      ~path:entry.Provider_context.path;
+      ~path:entry.Provider_context.path
+      ~start_time;
 
     (match mode with
     | Compute_tast_and_errors ->
diff --git a/hphp/hack/src/stubs/logging/hackEventLogger.ml b/hphp/hack/src/stubs/logging/hackEventLogger.ml
index e02a2dcb6e1..b0fff716d5f 100644
--- a/hphp/hack/src/stubs/logging/hackEventLogger.ml
+++ b/hphp/hack/src/stubs/logging/hackEventLogger.ml
@@ -453,7 +453,7 @@ let worker_exception _ = ()
 module ProfileTypeCheck = struct
   let process_file ~recheck_id:_ ~path:_ ~telemetry:_ = ()
 
-  let compute_tast ~path:_ ~telemetry:_ = ()
+  let compute_tast ~path:_ ~telemetry:_ ~start_time:_ = ()
 
   let get_telemetry_url ~init_id:_ ~recheck_id:_ = ""
 end
-- 
2.11.4.GIT