From 7077bddc24d6019aa7d0b3ed3215f7aaabe16c30 Mon Sep 17 00:00:00 2001 From: Henri Verroken Date: Fri, 11 Jun 2021 02:21:01 -0700 Subject: [PATCH] Log precomputed saved-state info + bitness in saved-state telemetry Reviewed By: ljw1004 Differential Revision: D29027255 fbshipit-source-id: 075d296cbe0aee6cc660e65b7e921bf8fab77539 --- hphp/hack/src/server/serverInitTypes.ml | 2 +- hphp/hack/src/server/serverLazyInit.ml | 2 ++ hphp/hack/src/stubs/logging/hackEventLogger.ml | 4 +++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hphp/hack/src/server/serverInitTypes.ml b/hphp/hack/src/server/serverInitTypes.ml index 6a85f53f968..9d75720096e 100644 --- a/hphp/hack/src/server/serverInitTypes.ml +++ b/hphp/hack/src/server/serverInitTypes.ml @@ -23,7 +23,7 @@ type load_state_error = } type load_state_approach = - | Precomputed of (ServerArgs.saved_state_target_info[@opaque]) + | Precomputed of ServerArgs.saved_state_target_info | Load_state_natively | Load_state_natively_with_target of (ServerMonitorUtils.target_saved_state[@opaque]) diff --git a/hphp/hack/src/server/serverLazyInit.ml b/hphp/hack/src/server/serverLazyInit.ml index b4119be6327..99ae1583fcb 100644 --- a/hphp/hack/src/server/serverLazyInit.ml +++ b/hphp/hack/src/server/serverLazyInit.ml @@ -1438,6 +1438,8 @@ let saved_state_init HackEventLogger.saved_state_download_and_load_done ~load_state_approach:(show_load_state_approach load_state_approach) ~success:(Result.is_ok state_result) + ~load_state_natively_64bit: + genv.local_config.ServerLocalConfig.load_state_natively_64bit t; match state_result with | Error err -> Error err diff --git a/hphp/hack/src/stubs/logging/hackEventLogger.ml b/hphp/hack/src/stubs/logging/hackEventLogger.ml index 6d32e58b711..fb73a123cbc 100644 --- a/hphp/hack/src/stubs/logging/hackEventLogger.ml +++ b/hphp/hack/src/stubs/logging/hackEventLogger.ml @@ -107,7 +107,9 @@ let server_is_ready _ = () let load_deptable_end _ = () -let saved_state_download_and_load_done ~load_state_approach:_ ~success:_ _ = () +let saved_state_download_and_load_done + ~load_state_approach:_ ~success:_ ~load_state_natively_64bit:_ _ = + () let tried_to_be_hg_aware_with_precomputed_saved_state_warning _ = () -- 2.11.4.GIT