From 52b05bf4cc35f15c0efa5d8db3ecd63c2e6f7536 Mon Sep 17 00:00:00 2001 From: Jason Reed Date: Fri, 21 Nov 2014 07:10:58 -0800 Subject: [PATCH] fix broken scuba logging Summary: Return back to ClientBuild when we're successful so we log CLIENT_BUILD_FINISH. This isn't a disaster since we still have basically the same data spread out in scuba table hh_build_steps, but might as well fix this. Reviewed By: @paulcavallaro Differential Revision: D1694667 Signature: t1:1694667:1416516191:54be6b1c677a9316acfcbad123e8672a6ea8b35b --- hphp/hack/src/client/clientBuild.ml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hphp/hack/src/client/clientBuild.ml b/hphp/hack/src/client/clientBuild.ml index c49393c43d1..5f88de347a6 100644 --- a/hphp/hack/src/client/clientBuild.ml +++ b/hphp/hack/src/client/clientBuild.ml @@ -87,7 +87,9 @@ let rec main_ env retries = | ServerMsg.BUILD_ERROR s -> exit_code := 2; print_endline s done with End_of_file -> - exit (!exit_code) + if !exit_code = 0 + then () + else exit (!exit_code) end | resp -> Printf.printf "Unexpected server response %s.\n%!" (ServerMsg.response_to_string resp) -- 2.11.4.GIT