From 439e3e81e28918714978db9f4b8d50290063f847 Mon Sep 17 00:00:00 2001 From: Vincent Siles Date: Tue, 1 Oct 2019 01:12:07 -0700 Subject: [PATCH] implement two functions in emitter Summary: These two functions are necessary to run a minimal PU website example. Reviewed By: vassilmladenov Differential Revision: D17665824 fbshipit-source-id: 258a5d5ea53b457917e1fd766f7a7d6c7c182c34 --- hphp/hack/src/hhbc/emit_type_hint.ml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hphp/hack/src/hhbc/emit_type_hint.ml b/hphp/hack/src/hhbc/emit_type_hint.ml index c05f8a89c87..5af7f3585bb 100644 --- a/hphp/hack/src/hhbc/emit_type_hint.ml +++ b/hphp/hack/src/hhbc/emit_type_hint.ml @@ -126,7 +126,8 @@ and fmt_hint ~tparams ~namespace ?(strip_tparams = false) (pos, h) = | Aast.Hthis -> fmt_name_or_prim (pos, SN.Typehints.this) | Aast.Hdynamic -> fmt_name_or_prim (pos, SN.Typehints.dynamic) | Aast.Hnothing -> fmt_name_or_prim (pos, SN.Typehints.nothing) - | Aast.Hpu_access _ -> failwith "TODO(T36532263) fmt_hint" + | Aast.Hpu_access (h, sid) -> + "(" ^ fmt_hint ~tparams ~namespace h ^ ":@" ^ snd sid ^ ")" and fmt_hints ~tparams ~namespace hints = String.concat ~sep:", " (List.map hints (fmt_hint ~tparams ~namespace)) @@ -267,7 +268,7 @@ let rec hint_to_type_constraint ~kind ~tparams ~skipawaitable ~namespace (p, h) | Aast.Hthis -> happly_helper (p, SN.Typehints.this) | Aast.Hnothing -> happly_helper (p, SN.Typehints.nothing) | Aast.Habstr s -> happly_helper (p, s) - | Aast.Hpu_access _ -> failwith "TODO(T36532263) hint_to_type_constraint" + | Aast.Hpu_access _ -> TC.make None [] and make_tc_with_flags_if_non_empty_flags ~kind ~tparams ~skipawaitable ~namespace t flags = -- 2.11.4.GIT