From 3286e1d7c089b6d1096743ab17cba3d85c2c2568 Mon Sep 17 00:00:00 2001
From: bsimmers <bsimmers@fb.com>
Date: Thu, 7 Feb 2013 18:14:41 -0800
Subject: [PATCH] Check RuntimeOption::RepoCommit in Repo::commitUnit instead
 of callers

---
 hphp/compiler/analysis/emitter.cpp | 4 +---
 hphp/runtime/vm/repo.cpp           | 2 ++
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hphp/compiler/analysis/emitter.cpp b/hphp/compiler/analysis/emitter.cpp
index b0efcb6feac..6779e4478ab 100644
--- a/hphp/compiler/analysis/emitter.cpp
+++ b/hphp/compiler/analysis/emitter.cpp
@@ -7359,9 +7359,7 @@ Unit* hphp_compiler_parse(const char* code, int codeLen, const MD5& md5,
     fsp->analyzeProgram(ar);
 
     UnitEmitter* ue = emitHHBCUnitEmitter(ar, fsp, md5);
-    if (RuntimeOption::RepoCommit) {
-      Repo::get().commitUnit(ue, unitOrigin);
-    }
+    Repo::get().commitUnit(ue, unitOrigin);
     Unit* unit = ue->create();
     delete ue;
     return unit;
diff --git a/hphp/runtime/vm/repo.cpp b/hphp/runtime/vm/repo.cpp
index bbaaeaa529f..0ec0cbe6dd8 100644
--- a/hphp/runtime/vm/repo.cpp
+++ b/hphp/runtime/vm/repo.cpp
@@ -320,6 +320,8 @@ bool Repo::insertUnit(UnitEmitter* ue, UnitOrigin unitOrigin, RepoTxn& txn) {
 }
 
 void Repo::commitUnit(UnitEmitter* ue, UnitOrigin unitOrigin) {
+  if (!RuntimeOption::RepoCommit) return;
+
   try {
     commitMd5(unitOrigin, ue);
     ue->commit(unitOrigin);
-- 
2.11.4.GIT