From 25f2e38550cc921e3613b24fc35820e4f0f6861f Mon Sep 17 00:00:00 2001 From: Jan Oravec Date: Thu, 27 Jun 2019 20:55:20 -0700 Subject: [PATCH] show(IRGS): show all elements on the stack, not just half Summary: stackDepth is the thing that indicates total number of elements, spOffset is just a current cursor that gets updated with every iteration. If we are iterating until spOffset and decrementing spOffset at the same time, we print only half of stack items. Reviewed By: alexeyt Differential Revision: D16041188 fbshipit-source-id: 0b4c954acf496d5a4484dac899d9ad2eb1a6dfbd --- hphp/runtime/vm/jit/irgen-state.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hphp/runtime/vm/jit/irgen-state.cpp b/hphp/runtime/vm/jit/irgen-state.cpp index e97ca84d98d..2e9727e3191 100644 --- a/hphp/runtime/vm/jit/irgen-state.cpp +++ b/hphp/runtime/vm/jit/irgen-state.cpp @@ -112,7 +112,7 @@ std::string show(const IRGS& irgs) { stackDepth).str()); assertx(spOffset <= curFunc(irgs)->maxStackCells()); - for (auto i = 0; i < spOffset; ) { + for (auto i = 0; i < stackDepth; ) { if (checkFpi()) { i += kNumActRecCells; continue; -- 2.11.4.GIT