From 0bb7f258ab0f63f354a3eedb58c950ae9ba5593d Mon Sep 17 00:00:00 2001 From: Catherine Gasnier Date: Tue, 12 Apr 2022 03:46:39 -0700 Subject: [PATCH] Telemetry: remove is_lazy_incremental Summary: I don't trust how is_lazy_incremental is handled. It's a global reference that sometimes gets set with a setter. Looking at code around that reference in HackEventLogger, it seems non-trivial to get it right, and impossible to convince oneself it is correct. Besides, for some events like recheck_end event, for example, it's completely meaningless because a "recheck" is a loop with multiple checks per iterations, where each check can either be lazy or full. We now have a check_kind field which is properly set with a with_check_kind helper, so is_lazy_incremental is redundant. Reviewed By: ljw1004 Differential Revision: D35547976 fbshipit-source-id: a9c0f23e19f1ed9029ddc36c7c93fc0cdc83952e --- hphp/hack/src/server/serverTypeCheck.ml | 3 --- hphp/hack/src/stubs/logging/hackEventLogger.ml | 2 -- 2 files changed, 5 deletions(-) diff --git a/hphp/hack/src/server/serverTypeCheck.ml b/hphp/hack/src/server/serverTypeCheck.ml index 9bbeb962fe5..8d447d01e6c 100644 --- a/hphp/hack/src/server/serverTypeCheck.ml +++ b/hphp/hack/src/server/serverTypeCheck.ml @@ -1955,9 +1955,6 @@ let type_check_unsafe genv env kind start_time profiling = |> Telemetry.string_ ~key:"kind" ~value:check_kind |> Telemetry.duration ~key:"start" ~start_time in - (match kind with - | CheckKind.Lazy -> HackEventLogger.set_lazy_incremental () - | CheckKind.Full -> ()); (* CAUTION! Lots of alerts/dashboards depend on the exact string of check_kind and check_reason *) HackEventLogger.with_check_kind ~check_kind ~check_reason @@ fun () -> diff --git a/hphp/hack/src/stubs/logging/hackEventLogger.ml b/hphp/hack/src/stubs/logging/hackEventLogger.ml index 97c7264bf5d..31ccd9a0cdb 100644 --- a/hphp/hack/src/stubs/logging/hackEventLogger.ml +++ b/hphp/hack/src/stubs/logging/hackEventLogger.ml @@ -75,8 +75,6 @@ let set_use_watchman _ = () let set_use_full_fidelity_parser _ = () -let set_lazy_incremental _ = () - let set_search_chunk_size _ = () let set_changed_mergebase _ = () -- 2.11.4.GIT