| commit | fe84f950c137ed23de0b7242d5859505dd260f69 | |
| author | Yu-Jung Lo <ylo@fb.com> | |
| Mon, 6 May 2019 06:08:51 +0000 (5 23:08 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Mon, 6 May 2019 06:12:09 +0000 (5 23:12 -0700) | ||
| tree | a39b728a89f2103ce04ef40d59f05af63bd16a33 | treesnapshot (tar.gz zip) |
| parent | 169203a6a2b5445654e32bc3a73c8634692174e2 | commitdiff |
lowptr optimization for ClsMethData
Summary:
ClsMethData only holds 2 pointers. At lowptr mode, the size of ClsMethData is 8 byte which can fit to Value union.
Hence, at lowptr mode, ClsMethData can be uncounted.
* We also need to specialize `LowPtrImpl<T, S>` for `RawStorage<low_storage_t>` type to make sure this class is trivially copyable. (This is used by LowPtr<Class> m_cls and LowPtr<Func> m_func fields in ClsMethData)
Reviewed By: markw65
Differential Revision: D14176650
fbshipit-source-id: 4fbe82f543536d8254dc425b139b7a52d1a0b136
Summary:
ClsMethData only holds 2 pointers. At lowptr mode, the size of ClsMethData is 8 byte which can fit to Value union.
Hence, at lowptr mode, ClsMethData can be uncounted.
* We also need to specialize `LowPtrImpl<T, S>` for `RawStorage<low_storage_t>` type to make sure this class is trivially copyable. (This is used by LowPtr<Class> m_cls and LowPtr<Func> m_func fields in ClsMethData)
Reviewed By: markw65
Differential Revision: D14176650
fbshipit-source-id: 4fbe82f543536d8254dc425b139b7a52d1a0b136
19 files changed: