| commit | fe284d785c7cb7b554f9ba66eb95e828c9e7ecea | |
| author | Alma Thaler <almathaler@fb.com> | |
| Tue, 19 Jul 2022 17:55:23 +0000 (19 10:55 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Tue, 19 Jul 2022 17:55:23 +0000 (19 10:55 -0700) | ||
| tree | cb5a1a8d70e97ce82eec63960336933d95eae043 | treesnapshot (tar.gz zip) |
| parent | 19395f33f61da0c8916d17150f248a5631ac916e | commitdiff |
Code Cleanup -- Assemble TV Triple Quote Helper -- 13274/14144
Summary:
Also fixed parsing user_attrs -- had to unescape the interior TV. Noticed that all TypedValue parsing followed this pattern so made use of `assemble_triple_quoted_typed_value` uniform.
```
"__EntryPoint"("""v:0:{}""")
```
The string within the parenthesis is the `user_attr_args`. Previously if these arguments included a string (which are escaped when printing), assembler would fail parsing.
Can now assemble 13274/14144
Reviewed By: hgoldstein
Differential Revision: D37885961
fbshipit-source-id: b59038f9c601d3edb4d6aabdfa2dbc22a4a4d000
Summary:
Also fixed parsing user_attrs -- had to unescape the interior TV. Noticed that all TypedValue parsing followed this pattern so made use of `assemble_triple_quoted_typed_value` uniform.
```
"__EntryPoint"("""v:0:{}""")
```
The string within the parenthesis is the `user_attr_args`. Previously if these arguments included a string (which are escaped when printing), assembler would fail parsing.
Can now assemble 13274/14144
Reviewed By: hgoldstein
Differential Revision: D37885961
fbshipit-source-id: b59038f9c601d3edb4d6aabdfa2dbc22a4a4d000
| hphp/hack/src/hackc/hackc/assemble.rs | diffblobblamehistory |