| commit | fb753613202d769cc9d2622f449c93238b50d79d | |
| author | Owen Yamauchi <oyamauchi@fb.com> | |
| Mon, 25 Aug 2014 15:53:31 +0000 (25 08:53 -0700) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Mon, 25 Aug 2014 16:10:08 +0000 (25 09:10 -0700) | ||
| tree | c2ddcdccd1c5cc39163c803db2b7aa811acbf65a | treesnapshot (tar.gz zip) |
| parent | 87f848b8fc2ac52003ec550de874c74adfee681c | commitdiff |
Delete unused stat counters
Summary: All of these are unused. I suspect some of them were originally meant to
count something that we still care about (e.g. tracelet guard
executions?) but the callsites have bitrotted away.
I think we'll need automated testing if we care about a particular stat
enough to keep it. I'd like to check this diff in as-is, but it's also
partially a forcing function to get people to reinstate stat counters
that they actually care about.
Reviewed By: @edwinsmith
Differential Revision: D1515024
Summary: All of these are unused. I suspect some of them were originally meant to
count something that we still care about (e.g. tracelet guard
executions?) but the callsites have bitrotted away.
I think we'll need automated testing if we care about a particular stat
enough to keep it. I'd like to check this diff in as-is, but it's also
partially a forcing function to get people to reinstate stat counters
that they actually care about.
Reviewed By: @edwinsmith
Differential Revision: D1515024
| hphp/runtime/base/stats.h | diffblobblamehistory |