Do not convert Int64.t to isize
commitfb18c81995f04e75bbf02e7245a8ae52c3b7c7cf
authorJake Bailey (Hacklang) <jakebailey@fb.com>
Wed, 3 Nov 2021 02:32:38 +0000 (2 19:32 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 3 Nov 2021 02:34:14 +0000 (2 19:34 -0700)
tree3cd141f0818c2e4f7e71b921981eee99a1a6d470
parent80fb78a9d8ba79b8d33572e76f9464294589c77c
Do not convert Int64.t to isize

Summary: If hh_oxidize represents Int64.t as isize, we will have crashes at runtime: the FromOcamlRep implementation of isize expects the value to be an unboxed int, but Int64.t is a boxed int. We should refrain from converting types containing Int64.t.

Reviewed By: bobrenjc93

Differential Revision: D32074668

fbshipit-source-id: 7e277bf8be47ac7fb69fb81967a5d3dd57559d26
hphp/hack/src/hh_oxidize/convert_type.ml
hphp/hack/src/hh_oxidize/convert_type_decl.ml
hphp/hack/src/oxidized/gen/file_info.rs
hphp/hack/src/oxidized_by_ref/extern_types.txt
hphp/hack/src/oxidized_by_ref/gen/file_info.rs