| commit | fa5b05e2046f146203e0bd49201b743468b59c7d | |
| author | Joel Marcey <joelm@fb.com> | |
| Wed, 6 Nov 2013 05:44:42 +0000 (5 21:44 -0800) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Wed, 6 Nov 2013 17:29:19 +0000 (6 09:29 -0800) | ||
| tree | 5ec9170bb2d0192422107df06c6060d8fd5f4a01 | treesnapshot (tar.gz zip) |
| parent | 5036732b47abdc943b45f2254439e62aff3c1ebc | commitdiff |
Fix "Nothing to do" errors coming from PHPUnit test suite
We were getting errors like: PHPUnit_Framework_Exception: HipHop Notice: Nothing to do. Either pass a .php file to run, or use -m server.
It had to do with running php in processes and passing php code via stdin. We need the php wrapper/symlink to hhvm instead of the explicit hhvm binary.
The fix was to fork phpunit, make a change to their getphpbinary() function to check for an environment variable that we then set in this script. Then we upstreamed that fix to the master phphunit branch and it was quickly accepted (that was nice!)
Also added @elgenie fork for Slim as well.
Reviewed By: @ptarjan
Differential Revision: D1043544
We were getting errors like: PHPUnit_Framework_Exception: HipHop Notice: Nothing to do. Either pass a .php file to run, or use -m server.
It had to do with running php in processes and passing php code via stdin. We need the php wrapper/symlink to hhvm instead of the explicit hhvm binary.
The fix was to fork phpunit, make a change to their getphpbinary() function to check for an environment variable that we then set in this script. Then we upstreamed that fix to the master phphunit branch and it was quickly accepted (that was nice!)
Also added @elgenie fork for Slim as well.
Reviewed By: @ptarjan
Differential Revision: D1043544
| hphp/test/frameworks/results/phpunit.expect | diffblobblamehistory | |
| hphp/test/frameworks/results/slim.expect | diffblobblamehistory | |
| hphp/test/frameworks/run.php | diffblobblamehistory |