| commit | fa23fd50c869719a1ce4aa2b75c248dc0686d814 | |
| author | Francesco Zappa Nardelli <fzn@meta.com> | |
| Fri, 21 Oct 2022 18:09:10 +0000 (21 11:09 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 21 Oct 2022 18:09:10 +0000 (21 11:09 -0700) | ||
| tree | 94e13b53ced6a1a0b3f32016e9d6e4b47d320904 | treesnapshot (tar.gz zip) |
| parent | 9e8c17335bca1dc54ad881db92fe5e8f7b9d6c39 | commitdiff |
disable runtime enforcement of require class constraints for mock classes
Summary:
A trait with a `require class C` constraints can only be used by class `C`, which must be final. This is enforced by HHVM when loading the class that uses the trait with the constraint.
HHVM enforcement is however too strict in presence of mock classes (see test mock.php in this diff). This diff disables HHVM enforcement for classes with the `<<__MockClass>>` attribute.
Additionally, this diff improves the error message printed when HHVM enforcement of `require class` constraints detects an error.
Reviewed By: ricklavoie
Differential Revision: D40547447
fbshipit-source-id: 56acc7e2c0a8abdb52b5d465b17b7f8b392bf118
Summary:
A trait with a `require class C` constraints can only be used by class `C`, which must be final. This is enforced by HHVM when loading the class that uses the trait with the constraint.
HHVM enforcement is however too strict in presence of mock classes (see test mock.php in this diff). This diff disables HHVM enforcement for classes with the `<<__MockClass>>` attribute.
Additionally, this diff improves the error message printed when HHVM enforcement of `require class` constraints detects an error.
Reviewed By: ricklavoie
Differential Revision: D40547447
fbshipit-source-id: 56acc7e2c0a8abdb52b5d465b17b7f8b392bf118
13 files changed: