| commit | fa20c934ed9d81a3bd7b58e5b830b9557783c98e | |
| author | Mark Williams <mwilliams@fb.com> | |
| Tue, 17 Jan 2017 15:15:57 +0000 (17 07:15 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 17 Jan 2017 15:29:51 +0000 (17 07:29 -0800) | ||
| tree | 58feb6c2cc5d214f759e07cf056a63094bc2de4f | treesnapshot (tar.gz zip) |
| parent | 974db7a36039aca410cb35fb92e7b5cda27012e9 | commitdiff |
Fix flags for FCallAwait
Summary:
FPassRNop marks itself canConstProp and nothrow, which meant that an
FCallAwait with a constant output (eg if we know it returns null, or
true) could be constant propagated away. In debug builds we would then
assert while trying to pop its arguments (because they're F flavored).
Reviewed By: ricklavoie
Differential Revision: D4422091
fbshipit-source-id: a736970b5939c72209ee20415f64850d36ab9955
Summary:
FPassRNop marks itself canConstProp and nothrow, which meant that an
FCallAwait with a constant output (eg if we know it returns null, or
true) could be constant propagated away. In debug builds we would then
assert while trying to pop its arguments (because they're F flavored).
Reviewed By: ricklavoie
Differential Revision: D4422091
fbshipit-source-id: a736970b5939c72209ee20415f64850d36ab9955
| hphp/hhbbc/interp.cpp | diffblobblamehistory |