| commit | f961e932c45a2fbfff10225020ccac3284749b6e | |
| author | Shaunak Kishore <kshaunak@fb.com> | |
| Fri, 19 Mar 2021 07:55:57 +0000 (19 00:55 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 19 Mar 2021 07:58:49 +0000 (19 00:58 -0700) | ||
| tree | 8a4b42a0fcb8745b91108e742864992cabe3d7d8 | treesnapshot (tar.gz zip) |
| parent | 0dfdb18571c697830df4842053c399baf8b7b331 | commitdiff |
Get most remaining nohadva tests working
Summary:
The tests in hphp/test/slow/array_provenance are not needed after HAM unification is complete.
Outside of that directory, we should have very few nohadva tests. This diff adds expect files for most of them. Along the way, I discovered a small behavior: flipping the HAM unification switch also hardens clsmeth-non-clsmeth comparison warnings into errors. I'm okay with making this change as it hasn't caused problems for us yet, but we can take a quick look at our logging to see how common it is.
Differential Revision: D27159566
fbshipit-source-id: a9576bd84b945ef502138ee2fd8f7d2ef19c8434
Summary:
The tests in hphp/test/slow/array_provenance are not needed after HAM unification is complete.
Outside of that directory, we should have very few nohadva tests. This diff adds expect files for most of them. Along the way, I discovered a small behavior: flipping the HAM unification switch also hardens clsmeth-non-clsmeth comparison warnings into errors. I'm okay with making this change as it hasn't caused problems for us yet, but we can take a quick look at our logging to see how common it is.
Differential Revision: D27159566
fbshipit-source-id: a9576bd84b945ef502138ee2fd8f7d2ef19c8434
155 files changed: