| commit | f84f83ae4d78b52098e29ff298c5e55111e49fc2 | |
| author | Thomas Jiang <thomasjiang@fb.com> | |
| Thu, 24 Oct 2019 04:49:48 +0000 (23 21:49 -0700) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 24 Oct 2019 04:53:47 +0000 (23 21:53 -0700) | ||
| tree | e08b3a1c76f222ed4131dffc3c89477f12830b70 | treesnapshot (tar.gz zip) |
| parent | e8665400606971f2824d284bac8039f21ce30462 | commitdiff |
Elaborate xml names
Summary:
We currently perform namespace elaboration all over the place - such as in naming and in codegen. If we are able to extract the namespace elaboration into one pass, we can remove having separate logic in naming and codegen and have it all in one place.
The plan is to
1.) Create an endo visitor that performs just namespace elaboration
2.) Move all of the elaboration from naming into it
3.) Add this pass into the codegen pass and see if codegen produces different bytecode
This diff elaborates Id nodes in xml nodes
Reviewed By: kmeht
Differential Revision: D17847134
fbshipit-source-id: a5c684565867d3d33bcd757a266c17359edf06ed
Summary:
We currently perform namespace elaboration all over the place - such as in naming and in codegen. If we are able to extract the namespace elaboration into one pass, we can remove having separate logic in naming and codegen and have it all in one place.
The plan is to
1.) Create an endo visitor that performs just namespace elaboration
2.) Move all of the elaboration from naming into it
3.) Add this pass into the codegen pass and see if codegen produces different bytecode
This diff elaborates Id nodes in xml nodes
Reviewed By: kmeht
Differential Revision: D17847134
fbshipit-source-id: a5c684565867d3d33bcd757a266c17359edf06ed
| hphp/hack/src/naming/elaborate_namespaces_endo.ml | diffblobblamehistory | |
| hphp/hack/src/naming/naming.ml | diffblobblamehistory |