Make intish cast explicit in unpack
commitf84da1fab21133e24ea3dcfb74f269fd526e51ec
authorJoseph Griego <jgriego@fb.com>
Thu, 15 Nov 2018 22:36:33 +0000 (15 14:36 -0800)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Thu, 15 Nov 2018 22:43:35 +0000 (15 14:43 -0800)
tree84c61e9840b91d335b0e3afb750c96311140c3ff
parent69d2eacfc6fc6ed4e2ccfd8630db20eb7cf77977
Make intish cast explicit in unpack

Summary:
What it says on the tin. We construct a name for the key from the
provided name in the format string and the number (if the key in question is
repeated)

Reviewed By: mxw

Differential Revision: D13051023

fbshipit-source-id: 27ef7134d82a15bb2c9467b0af9b8509bee84e7b
hphp/runtime/base/zend-pack.cpp
hphp/runtime/ext/std/ext_std_misc.cpp
hphp/test/slow/hack_arr_compat/unpack.php [new file with mode: 0644]
hphp/test/slow/hack_arr_compat/unpack.php.expect [new file with mode: 0644]
hphp/test/slow/hack_arr_compat/unpack.php.hphp_opts [new file with mode: 0644]
hphp/test/slow/hack_arr_compat/unpack.php.opts [new file with mode: 0644]