| commit | f620c88d2431b3081225ba1f175f7ca174f1f21e | |
| author | Joel Marcey <joelm@fb.com> | |
| Fri, 13 Dec 2013 16:37:14 +0000 (13 08:37 -0800) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Fri, 13 Dec 2013 20:39:26 +0000 (13 12:39 -0800) | ||
| tree | 73c9169fccbf570e9cb22bb92499604d6abdd1c1 | treesnapshot (tar.gz zip) |
| parent | c6b4136ac7476044629e5b8a14c310f865d92104 | commitdiff |
Avoid post test fatals from getting in the way of stats
This diff should hopefully help the cronjob run better.
The cronjob and my local runs were getting errors like this:
The stats file for joomla is corrupt! It should only have test names and statuses in it.
We were getting this because of hhvm cleanup core dumps, etc. after a test was run. Instead of printing stats in the stats file, we were printing this fatal information, which corrupted the stats file.
So, I captured this fatal information and directed it to the fatals file instead.
Reviewed By: @ptarjan
Differential Revision: D1097602
This diff should hopefully help the cronjob run better.
The cronjob and my local runs were getting errors like this:
The stats file for joomla is corrupt! It should only have test names and statuses in it.
We were getting this because of hhvm cleanup core dumps, etc. after a test was run. Instead of printing stats in the stats file, we were printing this fatal information, which corrupted the stats file.
So, I captured this fatal information and directed it to the fatals file instead.
Reviewed By: @ptarjan
Differential Revision: D1097602
| hphp/test/frameworks/run.php | diffblobblamehistory |