Preemptively update tests for UndefinedVariableException 14/n
commitf61ac92cb550264f576e43ece94a0d6599d4d78c
authorKaty Voor <voork@fb.com>
Thu, 21 Jan 2021 03:05:54 +0000 (20 19:05 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 21 Jan 2021 03:09:33 +0000 (20 19:09 -0800)
treee03bf6d5b2814481b2d9e24805fc808b63f35bd5
parente58e85d7d410778455366de8555ceba1b2d4077a
Preemptively update tests for UndefinedVariableException 14/n

Summary:
From summary 1/n:
- Would like to have UndefinedVariableException fatal in HHVM instead of thrown in www.
- There are ~500 tests, so in order to make code review possible, I'm breaking up tests before landing that change

These tests are checking an array of inputs on different functions. Since undefined variable will always throw an exception, it seem redundant to pull these arguments out of the array into a try catch for each test, and wouldn't test the function these tests are testing. So for these, we should remove undefined/unset args from the array of inputs to be tested.

- These changes were largely generated with sed, and are nearly all the same

Reviewed By: ricklavoie

Differential Revision: D25976339

fbshipit-source-id: f3ef316e3022e384997556a16ef190b52a0065f2
hphp/test/zend/good/ext/xml/tests/utf8_decode_variation1.php
hphp/test/zend/good/ext/xml/tests/utf8_decode_variation1.php.expectf
hphp/test/zend/good/ext/xml/tests/utf8_encode_variation1.php
hphp/test/zend/good/ext/xml/tests/utf8_encode_variation1.php.expectf
hphp/test/zend/good/ext/xml/tests/xml_parser_get_option_variation2.php
hphp/test/zend/good/ext/xml/tests/xml_parser_get_option_variation2.php.expectf
hphp/test/zend/good/ext/xml/tests/xml_parser_set_option_variation2.php
hphp/test/zend/good/ext/xml/tests/xml_parser_set_option_variation2.php.expectf
hphp/test/zend/good/ext/xml/tests/xml_parser_set_option_variation3.php
hphp/test/zend/good/ext/xml/tests/xml_parser_set_option_variation3.php.expectf