| commit | f5db57c85ad6e8bdb868f25f9d02ffa8d1bf580d | |
| author | Alexey Toptygin <alexeyt@fb.com> | |
| Sun, 8 Dec 2019 07:45:12 +0000 (7 23:45 -0800) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Sun, 8 Dec 2019 07:48:56 +0000 (7 23:48 -0800) | ||
| tree | 45a423b0fa6750f67725d50d133bf051ed8beb02 | treesnapshot (tar.gz zip) |
| parent | 79a4f072318a100339821432849b69a644492657 | commitdiff |
Fix line numbers in suspended frames when optimizing.
Summary:
Instead of storing the offset we resume at in resumables, store the offset we suspended at. This doesn't affect the jit, since it uses a separate resume address that isn't changing. In slow resume paths in the interpreter and debugger we can compute the resume offset from the suspend offset.
This allows backtraces to have correct line numbers for suspended frames when the optimizer removes bytecodes after e.g. an Await and the bytecode we resume at is at a line far from the place we suspended.
Reviewed By: ricklavoie
Differential Revision: D18874724
fbshipit-source-id: c1edd6eb7ca572a340f99a0cc7c109a2d4d3acfc
Summary:
Instead of storing the offset we resume at in resumables, store the offset we suspended at. This doesn't affect the jit, since it uses a separate resume address that isn't changing. In slow resume paths in the interpreter and debugger we can compute the resume offset from the suspend offset.
This allows backtraces to have correct line numbers for suspended frames when the optimizer removes bytecodes after e.g. an Await and the bytecode we resume at is at a line far from the place we suspended.
Reviewed By: ricklavoie
Differential Revision: D18874724
fbshipit-source-id: c1edd6eb7ca572a340f99a0cc7c109a2d4d3acfc
19 files changed: