| commit | f55d56eba265ac5f170dd97c44aaae97ccfe432c | |
| author | Philip Hölzenspies <drphil@fb.com> | |
| Mon, 25 Sep 2017 12:28:18 +0000 (25 05:28 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Mon, 25 Sep 2017 12:37:27 +0000 (25 05:37 -0700) | ||
| tree | 13855923cf382168bc8940d68148faaad4c4cadb | treesnapshot (tar.gz zip) |
| parent | fce4f279535bfd8dd77c909b6b0e97175842bc6b | commitdiff |
Turn FFP errors upto 11; report everything
Summary:
So far, the lowerer for the Full Fidelity Parser propagated errors quietly. If the use site didn't ask for them, they would go unnoticed. To match the behaviour of `Parser_hack`, when `keep_errors` is set, no AST should be produced if there are parse errors.
This diff invokes `Full_fidelity_parser_errors.parse_errors` on the error at the bottom of the error stack (this was produced first). Since the desired behaviour is to bail without an AST, this is done prior to lowering.
Reviewed By: andrewjkennedy, hubyrod
Differential Revision: D5697549
fbshipit-source-id: 89aa9bd51e96df8a4bcd5cc8ef5f97d8531b65cd
Summary:
So far, the lowerer for the Full Fidelity Parser propagated errors quietly. If the use site didn't ask for them, they would go unnoticed. To match the behaviour of `Parser_hack`, when `keep_errors` is set, no AST should be produced if there are parse errors.
This diff invokes `Full_fidelity_parser_errors.parse_errors` on the error at the bottom of the error stack (this was produced first). Since the desired behaviour is to bail without an AST, this is done prior to lowering.
Reviewed By: andrewjkennedy, hubyrod
Differential Revision: D5697549
fbshipit-source-id: 89aa9bd51e96df8a4bcd5cc8ef5f97d8531b65cd
321 files changed: