| commit | f4e68f903471f106d803d597c9dfa8c07c44297b | |
| author | Sara Golemon <sgolemon@fb.com> | |
| Sat, 15 Nov 2014 22:15:20 +0000 (15 14:15 -0800) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Sat, 15 Nov 2014 22:30:30 +0000 (15 14:30 -0800) | ||
| tree | bc24f2871659bc696831683d9a9accfcede7cf5a | treesnapshot (tar.gz zip) |
| parent | b0a7c118d0585b6c769a7b8211694ee20d870c60 | commitdiff |
Allow non-static expressions in function parameter defaults
Summary: This is primarily for HNI expressions such as the following
in datetime:
function date(string $format, int $now = TimeStamp::Current());
HHVM compiles default arguments to Bytecode and jumps to the correct
location in the function for initialization anyway, so there's no real
need to limit the default to static expressions apart from PHP's
language design.
Closes #2886
Reviewed By: @paulbiss
Differential Revision: D1682957
Signature: t1:1682957:1416007027:42343f4baf80906e22308e1e1e91bea7027967d1
Summary: This is primarily for HNI expressions such as the following
in datetime:
function date(string $format, int $now = TimeStamp::Current());
HHVM compiles default arguments to Bytecode and jumps to the correct
location in the function for initialization anyway, so there's no real
need to limit the default to static expressions apart from PHP's
language design.
Closes #2886
Reviewed By: @paulbiss
Differential Revision: D1682957
Signature: t1:1682957:1416007027:42343f4baf80906e22308e1e1e91bea7027967d1
22 files changed: