| commit | f4adfc617f6ba6712fed0346240c3ec57d24c213 | |
| author | Thomas Jiang <thomasjiang@fb.com> | |
| Mon, 30 Sep 2019 18:58:13 +0000 (30 11:58 -0700) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Mon, 30 Sep 2019 19:04:50 +0000 (30 12:04 -0700) | ||
| tree | 103d7f391202f488257ef35b2e2df22b64674c20 | treesnapshot (tar.gz zip) |
| parent | 99bcb669126c0e6fc804583e8ece3d8ed931b775 | commitdiff |
Move __clone check to nast_check
Summary:
Trying to break up naming into separate components - This stack attempts to clean up and move error checks from naming.ml to into nast_check by converting them to nast_visitors. Some of these passes do not require names or calls to the naming table so they could be parser errors - but keeping them consistent until we decide what we want to do with them later.
Moves check of __clone to nast_check
Reviewed By: kmeht
Differential Revision: D17531455
fbshipit-source-id: a6cbaff8468fe29a598422661bff79d7ae31dfaa
Summary:
Trying to break up naming into separate components - This stack attempts to clean up and move error checks from naming.ml to into nast_check by converting them to nast_visitors. Some of these passes do not require names or calls to the naming table so they could be parser errors - but keeping them consistent until we decide what we want to do with them later.
Moves check of __clone to nast_check
Reviewed By: kmeht
Differential Revision: D17531455
fbshipit-source-id: a6cbaff8468fe29a598422661bff79d7ae31dfaa
| hphp/hack/src/naming/naming.ml | diffblobblamehistory | |
| hphp/hack/src/typing/nast_check/nast_class_method_check.ml | diffblobblamehistory |