Remove parsing support for ?>
commitf3ea5e70095a53a0184e7134836cb277eeca063d
authorWilfred Hughes <wilfred@fb.com>
Thu, 2 Apr 2020 17:16:09 +0000 (2 10:16 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 2 Apr 2020 17:21:10 +0000 (2 10:21 -0700)
treea4d640070d176bb9900c35043a2a043cb7c86a63
parent32880b3f90e18aa5f0073365324302a08e6f512e
Remove parsing support for ?>

Summary: `?>`, the closing short tag syntax, became a lowering error in D8069481 and a parsing error in D14378734. Remove the logic from the parser entirely: remove the token, and stop treating semicolons specially when a `?>` is present.

Reviewed By: fredemmott

Differential Revision: D20626318

fbshipit-source-id: 3d2159081c18d9113641843c92927a547d0afc3c
17 files changed:
hphp/hack/src/parser/core/lexer.rs
hphp/hack/src/parser/core/parser_trait.rs
hphp/hack/src/parser/core/statement_parser.rs
hphp/hack/src/parser/full_fidelity_token_kind.ml
hphp/hack/src/parser/js/full_fidelity_schema.json
hphp/hack/src/parser/schema/full_fidelity_schema.ml
hphp/hack/src/parser/schema/token_schema_definition.ml
hphp/hack/src/parser/syntax_error.rs
hphp/hack/src/parser/token_kind.rs
hphp/hack/test/full_fidelity/cases/test_php_blocks_errors.php.errors.exp
hphp/hack/test/full_fidelity/cases/test_php_blocks_errors.php.sexp.exp
hphp/test/slow/hack_mode/2204.php [deleted file]
hphp/test/slow/hack_mode/2204.php.expectf [deleted file]
hphp/test/slow/hack_mode/2204.php.hphp_opts [deleted file]
hphp/test/slow/hack_mode/2204.php.opts [deleted symlink]
hphp/test/slow/hack_mode/closing-tag-php.php [deleted file]
hphp/test/slow/hack_mode/closing-tag-php.php.expectf [deleted file]