| commit | f3566502c6ac5d5caafc584216d03374ed73ee23 | |
| author | Fred Emmott <fe@fb.com> | |
| Fri, 6 Apr 2018 16:40:43 +0000 (6 09:40 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 6 Apr 2018 16:43:01 +0000 (6 09:43 -0700) | ||
| tree | c22ace93dfae12a7ba338681d0e2feb6b5215e09 | treesnapshot (tar.gz zip) |
| parent | 93131086001beea4240891690b8ea07d2c10a3aa | commitdiff |
php7: implement array destructuring
Summary:
Goal is to allow `[$a, [$b, $c]] = [1, [2, 3]]`. This is done by:
- making `list()` an array literal
- allow assigning to array literals
- when we attempt to assign to an array literal, validate that it's a valid LHS
- allow any number of commas at any point in the literal in the parser as `[,,$three,,] = [1,2,3,4,5]` is valid
- in the emitter, raise a fatal if we have any empty values on an RHS, and ignore a single trailing comma
Making `[$a, $b]` a valid assignment_list isn't practical as that makes the
grammar ambiguous.
Not supported in HackC or the typechecker; that doesn't seem practical with the
3.25 timeline.
fixes facebook/hhvm#7535
Differential Revision: D7057672
fbshipit-source-id: 2447406b4665d0ab1930036517fe17601a23b1b3
Summary:
Goal is to allow `[$a, [$b, $c]] = [1, [2, 3]]`. This is done by:
- making `list()` an array literal
- allow assigning to array literals
- when we attempt to assign to an array literal, validate that it's a valid LHS
- allow any number of commas at any point in the literal in the parser as `[,,$three,,] = [1,2,3,4,5]` is valid
- in the emitter, raise a fatal if we have any empty values on an RHS, and ignore a single trailing comma
Making `[$a, $b]` a valid assignment_list isn't practical as that makes the
grammar ambiguous.
Not supported in HackC or the typechecker; that doesn't seem practical with the
3.25 timeline.
fixes facebook/hhvm#7535
Differential Revision: D7057672
fbshipit-source-id: 2447406b4665d0ab1930036517fe17601a23b1b3
21 files changed: