| commit | f2b45156bb26fccf11cef59e97bff04329aa75f5 | |
| author | Lucian Wischik <ljw@fb.com> | |
| Tue, 10 Dec 2019 04:56:27 +0000 (9 20:56 -0800) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Tue, 10 Dec 2019 05:02:24 +0000 (9 21:02 -0800) | ||
| tree | 46c0f318d716eba003ae73cb7e6305da3273b94e | treesnapshot (tar.gz zip) |
| parent | fe5edbf82e697ba7336d45bea5659906e5f40042 | commitdiff |
add types for CompletionItemResolve
Summary:
My goal is a single canonical place where we parse jsonrpc into an ADT. Formerly only Flow did this; now Hack will do it as well.
That ADT is `Lsp.lsp_message`. Flow never handled CompletionItemResolve, so we never noticed that the ADT lacked a constructor for it. This diff adds the constructor.
Reviewed By: arxanas
Differential Revision: D18874994
fbshipit-source-id: 15280bed7f892cda3e94b5533d524631ba72d331
Summary:
My goal is a single canonical place where we parse jsonrpc into an ADT. Formerly only Flow did this; now Hack will do it as well.
That ADT is `Lsp.lsp_message`. Flow never handled CompletionItemResolve, so we never noticed that the ADT lacked a constructor for it. This diff adds the constructor.
Reviewed By: arxanas
Differential Revision: D18874994
fbshipit-source-id: 15280bed7f892cda3e94b5533d524631ba72d331
| hphp/hack/src/utils/lsp/lsp_fmt.ml | diffblobblamehistory |