| commit | f22433ebe66a0b24ea2e324162dcab65eaef64ac | |
| author | Shaunak Kishore <kshaunak@fb.com> | |
| Thu, 8 Apr 2021 01:22:40 +0000 (7 18:22 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 8 Apr 2021 01:23:55 +0000 (7 18:23 -0700) | ||
| tree | 5cc007ffc77ced8a7ccf2291a82e11b1e8010577 | treesnapshot (tar.gz zip) |
| parent | 7780ef8452305b1c268c1bdf1b0370a1ffd6ea5f | commitdiff |
Eliminate APCHandle unwrap optimization
Summary:
I don't believe this optimization has any real effect. We co-allocate top-level arrays in APC and their handles, so doing the extra deference will actually prefetch the array's cache line. It shouldn't be a real cost.
I'd like to add logic into APCTypedValue::toLocal(). By unwrapping the value, we're skipping that logic.
Reviewed By: ricklavoie
Differential Revision: D27606151
fbshipit-source-id: ff5d7d63eb199f84c02c9033817b2ab4f6e276cc
Summary:
I don't believe this optimization has any real effect. We co-allocate top-level arrays in APC and their handles, so doing the extra deference will actually prefetch the array's cache line. It shouldn't be a real cost.
I'd like to add logic into APCTypedValue::toLocal(). By unwrapping the value, we're skipping that logic.
Reviewed By: ricklavoie
Differential Revision: D27606151
fbshipit-source-id: ff5d7d63eb199f84c02c9033817b2ab4f6e276cc
| hphp/runtime/base/concurrent-shared-store.cpp | diffblobblamehistory |