| commit | f1cc339a1701f0b0d89827fba94c72a3b94bfbb0 | |
| author | Jan Oravec <jan@fb.com> | |
| Mon, 23 Nov 2020 08:35:33 +0000 (23 00:35 -0800) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Mon, 23 Nov 2020 08:37:33 +0000 (23 00:37 -0800) | ||
| tree | e0e5aed2ec2f2d10e45ce72a809c31a4038b75ec | treesnapshot (tar.gz zip) |
| parent | 19fc5415d5b44c1c442f962922fdd5e9a00cc46e | commitdiff |
Fix flaky test/slow/async/resume_throw_hook_timeout.php
Summary:
Depending on where the timeout occurs, the fatal either reports the location or
it does not. The `%s` was intended to handle this optionality, but apparently
it does not match an empty string, which `%S` does, so let's use that.
Not sure why this test used to work until recently though. I remember observing
both situations locally when I added the test and `%s` seemed to work.
Reviewed By: ottoni
Differential Revision: D25158058
fbshipit-source-id: 7523456e847b3ff00d1b7aa16f7ee1ce9da1a1e4
Summary:
Depending on where the timeout occurs, the fatal either reports the location or
it does not. The `%s` was intended to handle this optionality, but apparently
it does not match an empty string, which `%S` does, so let's use that.
Not sure why this test used to work until recently though. I remember observing
both situations locally when I added the test and `%s` seemed to work.
Reviewed By: ottoni
Differential Revision: D25158058
fbshipit-source-id: 7523456e847b3ff00d1b7aa16f7ee1ce9da1a1e4
| hphp/test/slow/async/resume_throw_hook_timeout.php.expectf | diffblobblamehistory |